fix(trending): use bare type strings in trending winners queries#914
Merged
Conversation
Change the trending_results.type filter values from the Python-style "TrendingType.TRACKS" / "TrendingType.UNDERGROUND_TRACKS" to the bare "TRACKS" / "UNDERGROUND_TRACKS" stored in the table, and update the test fixtures to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
69e7ff5 to
c86817a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The trending winners endpoints filtered
trending_results.typeusing thePython-style enum strings
TrendingType.TRACKSandTrendingType.UNDERGROUND_TRACKS, but the values actually stored in thetable are the bare
TRACKS/UNDERGROUND_TRACKS. This swaps the queryfilter values to the bare strings and updates the test fixtures to match.
Changes
api/v1_tracks_trending_winners.go:TrendingType.TRACKS→TRACKSapi/v1_tracks_trending_underground_winners.go:TrendingType.UNDERGROUND_TRACKS→UNDERGROUND_TRACKSapi/testdata/trending_results_fixtures.go: updated fixturetypevalues to matchTesting
go test ./api/... -run 'TestGetTrendingWinnersTracks|TestGetTrendingUndergroundWinnersTracks' -v— all 8 tests pass.🤖 Generated with Claude Code